Solved - Keyboard Interrupts stop working after a few seconds

[DontYellAtMe]

Pretty much the title, I got my interrupts working about two weeks ago, but I have a bug I've tried everything to fix, and now I'm giving up and asking the internet. My keyboard ISR is meant to print the PS/2 scancode to the VGA text buffer, but they stop working after a few seconds of going fine. It does work fine for the first couple of seconds, so I don't think I've done a silly basic thing like not setting up the IDT, PIC, sending EOI's, or never reading the scancode port (0x60).

Solved:
I did do a silly thing, I forgot to add a ret at the end of some ASM functions.
Shot @Octocontrabass

[Octocontrabass]

I don't think I've done a silly basic thing like not setting up the IDT, PIC, sending EOI's, or never reading the scancode port (0x60).

Does forgetting the RET instruction at the end of some assembly functions count as a silly basic thing?

Is it normal for IRQ1 to occasionally have multiple bytes waiting in the PS/2 controller output buffer,

That can happen in virtual machines or when the PS/2 controller is emulated in SMM.

and should I be trying to read this in a while loop as described below?

Probably not. The PS/2 controller raises one IRQ per byte, so this could cause weird timing issues with the interrupt controller that result in lost or spurious IRQs.

[DontYellAtMe]

Does forgetting the RET instruction at the end of some assembly functions count as a silly basic thing?

I may have done one silly thing then.

Thank you so much, I've scanned that for days and days, put the code through every AI you can think of, and you've fixed it straight away

Your a G