OSDev.org

The Place to Start for Operating System Developers
It is currently Mon Sep 16, 2019 10:08 am

All times are UTC - 6 hours




Post new topic Reply to topic  [ 9 posts ] 

The answer:
True 24%  24%  [ 4 ]
False 6%  6%  [ 1 ]
Contradiction 71%  71%  [ 12 ]
Total votes : 17
Author Message
 Post subject: Poll & wikilink theming broken.
PostPosted: Tue Dec 14, 2010 4:26 pm 
Offline
Member
Member
User avatar

Joined: Wed Oct 18, 2006 3:45 am
Posts: 9284
Location: On the balcony, watching the Swedish Chef
It appears that some board styles cause the message "The submitted form was invalid" upon casting a vote. This applies at least to the MegaTokyo theme (which seems to be popular among the senior members), and maybe others.

You can get around the problem by switching your theme to prosilver (phpbb's bundled theme), but of course I'd like to see this fixed. Poll attached for testing purposes

Edit: As posted below, in some other themes, it appears that there's also no link to the Main_Page

Checklist:
SFCentar: no Wiki link.
eTech dark green: no Wiki link.
OMG Ponies: no Wiki link.
Voting: fixed

_________________
"Certainly avoid yourself. He is a newbie and might not realize it. You'll hate his code deeply a few years down the road." - Sortie
[ My OS ] [ VDisk/SFS ]


Last edited by Combuster on Fri Dec 24, 2010 3:38 am, edited 4 times in total.

Top
 Profile  
 
 Post subject: Re: Poll theming broken.
PostPosted: Tue Dec 14, 2010 4:50 pm 
Offline
Member
Member
User avatar

Joined: Thu Dec 21, 2006 7:42 pm
Posts: 1391
Location: Unknown. Momentum is pretty certain, however.
Doesn't work in Blue Moon either.

-JL

_________________
SeaOS: Adding VT-x, networking, and ARM support
dbittman on IRC, @danielbittman on twitter
https://dbittman.github.io


Top
 Profile  
 
 Post subject: Re: Poll theming broken.
PostPosted: Tue Dec 14, 2010 4:58 pm 
Offline
Member
Member

Joined: Sun Dec 14, 2008 1:53 pm
Posts: 76
Works for me using SkyBlue


Top
 Profile  
 
 Post subject: Re: Poll theming broken.
PostPosted: Tue Dec 14, 2010 7:29 pm 
Offline
Member
Member
User avatar

Joined: Sat Jan 15, 2005 12:00 am
Posts: 8561
Location: At his keyboard!
Hi,

The poll worked fine for me, using the "OMG Ponies" theme... :-)

[EDIT]
Ok, I just realised that for the "OMG Ponies" theme there is no link to the Wiki. I wonder if this explains why so many new members ask questions without checking the wiki first? :roll:
[/EDIT]


Cheers,

Brendan

_________________
For all things; perfection is, and will always remain, impossible to achieve in practice. However; by striving for perfection we create things that are as perfect as practically possible. Let the pursuit of perfection be our guide.


Top
 Profile  
 
 Post subject: Re: Poll theming broken.
PostPosted: Wed Dec 15, 2010 12:26 am 
Offline
Member
Member
User avatar

Joined: Thu Nov 16, 2006 12:01 pm
Posts: 7412
Location: Germany
SFCentar: Voting works, no Wiki link.
blackbox_blue: Voting broken, Wiki link available.
eTech dark green: Voting broken, no Wiki link.
subsilver: Voting works, Wiki link available.
mega-tokyo: Voting broken, Wiki link available.

_________________
Every good solution is obvious once you've found it.


Top
 Profile  
 
 Post subject: Re: Poll & wikilink theming broken.
PostPosted: Wed Dec 15, 2010 2:29 am 
Offline
Member
Member
User avatar

Joined: Wed Oct 18, 2006 3:45 am
Posts: 9284
Location: On the balcony, watching the Swedish Chef
And I thought only Alboin was using the ponies theme... Then again, I don't think the noobs are that likely to use it, as well as the fact that they do get the link before they register (since prosilver does work).

Updated the first post with the buglist so far.

_________________
"Certainly avoid yourself. He is a newbie and might not realize it. You'll hate his code deeply a few years down the road." - Sortie
[ My OS ] [ VDisk/SFS ]


Top
 Profile  
 
 Post subject: Re: Poll & wikilink theming broken.
PostPosted: Wed Dec 15, 2010 3:26 pm 
Offline
Member
Member
User avatar

Joined: Thu Dec 21, 2006 7:42 pm
Posts: 1391
Location: Unknown. Momentum is pretty certain, however.
They'd use it more if it were the default theme...*ahem* :D

-JL

_________________
SeaOS: Adding VT-x, networking, and ARM support
dbittman on IRC, @danielbittman on twitter
https://dbittman.github.io


Top
 Profile  
 
 Post subject: Re: Poll & wikilink theming broken.
PostPosted: Thu Dec 23, 2010 11:43 pm 
Offline
Site Admin
User avatar

Joined: Wed Oct 20, 2004 10:46 pm
Posts: 665
Location: Texas
MegaTokyo/template/viewtopic_body.html was missing a {S_FORM_TOKEN}. It was missing from the subsilver2 3.0.1 version of the file so any theme that began as a modified version of that theme was also missing the entry. Voting looks to be working on all themes now, if not then let me know.

The themes/templates have changed enough that we probably need to rebuild them. I tried a quick merge of the current css subsilver2-megatokyo differences and the result was unusable. We probably need to diff the 3.0.1 version of subsilver2 and MegaTokyo and try to build an updated version of MegaTokyo with 3.0.8 subsilver2 as the basis.


Top
 Profile  
 
 Post subject: Re: Wikilink theming broken.
PostPosted: Fri Dec 24, 2010 3:39 am 
Offline
Member
Member
User avatar

Joined: Wed Oct 18, 2006 3:45 am
Posts: 9284
Location: On the balcony, watching the Swedish Chef
Thanks for fixing the poll

_________________
"Certainly avoid yourself. He is a newbie and might not realize it. You'll hate his code deeply a few years down the road." - Sortie
[ My OS ] [ VDisk/SFS ]


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 9 posts ] 

All times are UTC - 6 hours


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group