OSDev.org
https://forum.osdev.org/

Poll & wikilink theming broken.
https://forum.osdev.org/viewtopic.php?f=6&t=22871
Page 1 of 1

Author:  Combuster [ Tue Dec 14, 2010 4:26 pm ]
Post subject:  Poll & wikilink theming broken.

It appears that some board styles cause the message "The submitted form was invalid" upon casting a vote. This applies at least to the MegaTokyo theme (which seems to be popular among the senior members), and maybe others.

You can get around the problem by switching your theme to prosilver (phpbb's bundled theme), but of course I'd like to see this fixed. Poll attached for testing purposes

Edit: As posted below, in some other themes, it appears that there's also no link to the Main_Page

Checklist:
SFCentar: no Wiki link.
eTech dark green: no Wiki link.
OMG Ponies: no Wiki link.
Voting: fixed

Author:  piranha [ Tue Dec 14, 2010 4:50 pm ]
Post subject:  Re: Poll theming broken.

Doesn't work in Blue Moon either.

-JL

Author:  computafreak [ Tue Dec 14, 2010 4:58 pm ]
Post subject:  Re: Poll theming broken.

Works for me using SkyBlue

Author:  Brendan [ Tue Dec 14, 2010 7:29 pm ]
Post subject:  Re: Poll theming broken.

Hi,

The poll worked fine for me, using the "OMG Ponies" theme... :-)

[EDIT]
Ok, I just realised that for the "OMG Ponies" theme there is no link to the Wiki. I wonder if this explains why so many new members ask questions without checking the wiki first? :roll:
[/EDIT]


Cheers,

Brendan

Author:  Solar [ Wed Dec 15, 2010 12:26 am ]
Post subject:  Re: Poll theming broken.

SFCentar: Voting works, no Wiki link.
blackbox_blue: Voting broken, Wiki link available.
eTech dark green: Voting broken, no Wiki link.
subsilver: Voting works, Wiki link available.
mega-tokyo: Voting broken, Wiki link available.

Author:  Combuster [ Wed Dec 15, 2010 2:29 am ]
Post subject:  Re: Poll & wikilink theming broken.

And I thought only Alboin was using the ponies theme... Then again, I don't think the noobs are that likely to use it, as well as the fact that they do get the link before they register (since prosilver does work).

Updated the first post with the buglist so far.

Author:  piranha [ Wed Dec 15, 2010 3:26 pm ]
Post subject:  Re: Poll & wikilink theming broken.

They'd use it more if it were the default theme...*ahem* :D

-JL

Author:  chase [ Thu Dec 23, 2010 11:43 pm ]
Post subject:  Re: Poll & wikilink theming broken.

MegaTokyo/template/viewtopic_body.html was missing a {S_FORM_TOKEN}. It was missing from the subsilver2 3.0.1 version of the file so any theme that began as a modified version of that theme was also missing the entry. Voting looks to be working on all themes now, if not then let me know.

The themes/templates have changed enough that we probably need to rebuild them. I tried a quick merge of the current css subsilver2-megatokyo differences and the result was unusable. We probably need to diff the 3.0.1 version of subsilver2 and MegaTokyo and try to build an updated version of MegaTokyo with 3.0.8 subsilver2 as the basis.

Author:  Combuster [ Fri Dec 24, 2010 3:39 am ]
Post subject:  Re: Wikilink theming broken.

Thanks for fixing the poll

Page 1 of 1 All times are UTC - 6 hours
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
http://www.phpbb.com/