OSDev.org

The Place to Start for Operating System Developers
It is currently Fri Mar 29, 2024 7:21 am

All times are UTC - 6 hours




Post new topic Reply to topic  [ 2 posts ] 
Author Message
 Post subject: VGA Driver Bug
PostPosted: Tue Oct 16, 2018 8:04 pm 
Offline

Joined: Wed Aug 15, 2018 7:43 pm
Posts: 10
I have been switching away from text mode and have started using VGA 320x200x256 as the main screen. But while I was implementing drawing methods, this little bug showed itself.
Image
I was going to just add one extra pixel to my rectangle method, but I could be looking over something way worse. Anyone have an idea of what is going on?
(VGA Driver Code)
https://pastebin.com/48MuAtJW


Top
 Profile  
 
 Post subject: Re: VGA Driver Bug
PostPosted: Tue Oct 16, 2018 9:20 pm 
Offline
Member
Member

Joined: Tue Mar 04, 2014 5:27 am
Posts: 1108
Missing a couple of -1's in rectangle().
Also incorrectly checking the ranges in setp(). Same problem: off by one.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 2 posts ] 

All times are UTC - 6 hours


Who is online

Users browsing this forum: Google [Bot] and 259 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group