OSDev.org

The Place to Start for Operating System Developers
It is currently Fri Sep 30, 2022 12:12 am

All times are UTC - 6 hours




Post new topic Reply to topic  [ 6 posts ] 
Author Message
 Post subject: [Real mode] PIT and Keyboard IRQs not firing on laptop
PostPosted: Mon Aug 08, 2022 7:57 am 
Offline
User avatar

Joined: Mon May 27, 2019 11:32 am
Posts: 6
Location: France
Hi all,

I am currently developing a small program purely in 16-bits assembly. This program is a sort of game working with software rendering using video mode 0x13.

I tested it on many emulators : QEMU, Bochs, VirtualBox, VMWare... They all work the same. I event tested it on an old desktop PC with UEFI and CSM for old-style booting, and it works! Until I decided to test it on another physical machine, a Toshiba Satellite L670 laptop.

What I see
The splash screen is displayed correctly. What this means is a lot : Back buffer over the 1 MiB limit works, font loading using int 0x13 works, and segments have all been loaded correctly. Hurray!
Although, after that, I have added a sort of "sleep" call which tells the game to wait for a second. The way this works is by trapping the CPU into a loop with a hlt, and testing the number of remaining frames.
Meanwhile, IRQ0 (the PIT) is triggered 30 times a second and decrements this counter. So, execution blocks until this countdown reaches 0.
But on the laptop I mentioned above, it simply hangs, and I can't figure out why. It doesn't go past the splash screen, even though everything else worked until this point.

What I have tried
- Yes, I have checked if I had set up the IVT correctly, and I did.
- Yes, I did call sti to re-enable interrupts.
- And yes, I am sending EOI at the end of my handlers.
I also tried removing ALL halts and wait calls to jump directly to the game's main loop. I do see the scene, the player's health, everything is as it should be. BUT, the keyboard is not responding. I have tried pressing all the keys I have bound to some action, and they all do nothing.
There are also some moving elements in the scene, which are staying absolutely still, which in turn means that the PIT's interrupt is not being picked up...

This is where I am currently. The bootloader loads the rest of the game fine. The game sets itself up, renders the splash screen, and then hangs on hlt, only on this Toshiba laptop. With all the tests I made, it does seem like my ISRs are not being called. And at this point, I am too afraid to try it on other laptops, as I don't know how they might react.

Any help would be apreciated.
Thanks!


Top
 Profile  
 
 Post subject: Re: [Real mode] PIT and Keyboard IRQs not firing on laptop
PostPosted: Mon Aug 08, 2022 10:44 am 
Offline
Member
Member

Joined: Wed Aug 30, 2017 8:24 am
Posts: 1338
Dave08 wrote:
What I have tried
- Yes, I have checked if I had set up the IVT correctly, and I did.
- Yes, I did call sti to re-enable interrupts.
- And yes, I am sending EOI at the end of my handlers.
So, your ISRs do not run, but the interrupt flag is set. Well, what else could it be? First order of business is going to be to establish some kind of debugger on the affected device. And you cannot read the keyboard. So how about instead of HLT, you run a busy-wait loop that prints some things every couple million TSC steps (so you RDTSC and do some things if any changes happened above the 20th bit or so)? Then you can try to find out what is going on yourself.

Not getting a PIT interrupt can be due to the PIT not making the interrupt, the PIC not receiving it, the PIC sending it to a different interrupt slot, or the CPU ignoring it. So first things first, I would check the various registers of the PIC that can be read without side effects and print them on screen. Then you can see if the PIT and keyboard interrupts are being generated. It is also possible that the IDTR contains weird values, so maybe try to print the results of "sidt" once in a while. Maybe the IVT at address 0 is not the one in use?

If you find that the interrupt is being generated, maybe create ISRs for every slot that just print "interrupt X happened" (excepting the BIOS interrupts, of course). That ought to show you where the interrupts land. You could write those as interdictors, so that the original routine is still executed after your debug print.
Dave08 wrote:
And at this point, I am too afraid to try it on other laptops, as I don't know how they might react.
It's gonna make the system spontaneously combust. In all seriousness, just try it. It is supremely unlikely that you would brick the system, and beyond that the worst that can happen is your game won't work. Oh well.

_________________
Carpe diem!


Top
 Profile  
 
 Post subject: Re: [Real mode] PIT and Keyboard IRQs not firing on laptop
PostPosted: Mon Aug 08, 2022 11:15 am 
Offline
Member
Member

Joined: Sat Nov 21, 2009 5:11 pm
Posts: 794
Possible causes:
- you are sending an EOI for an interrupt you did not handle, causing an endless stream of interrupts.
- interrupts are masked.
- a timer interrupt was somehow not handled.


Top
 Profile  
 
 Post subject: Re: [Real mode] PIT and Keyboard IRQs not firing on laptop
PostPosted: Mon Aug 08, 2022 11:47 am 
Offline
Member
Member

Joined: Mon Mar 25, 2013 7:01 pm
Posts: 4145
Dave08 wrote:
- Yes, I have checked if I had set up the IVT correctly, and I did.

Care to elaborate? There's a lot of things you could be doing when you say "set up the IVT".


Top
 Profile  
 
 Post subject: Re: [Real mode] PIT and Keyboard IRQs not firing on laptop
PostPosted: Mon Aug 08, 2022 1:13 pm 
Offline
User avatar

Joined: Mon May 27, 2019 11:32 am
Posts: 6
Location: France
I have tried explicitly setting the Master PIC mask to 0b10111100 (PIT, keyboard and floppy IRQs active), but it does not change anything.

Octocontrabass wrote:
Dave08 wrote:
- Yes, I have checked if I had set up the IVT correctly, and I did.

Care to elaborate? There's a lot of things you could be doing when you say "set up the IVT".

About setting the IVT, I have done this for the PIT :
Code:
mov word [0x20], _isr_timer
mov word [0x22], 0

...

_isr_timer:
    pusha
    ...

    mov al, 0x20
    out 0x20, al
    popa
    iret

I know it's correct, because it works on emulators and on my physical desktop. I also know that my laptop sets the IVT to memory location 0x0000:0x0000 because I tried hooking a handler for the breakpoint interrupt (INT 3) which simply set the first pixel red in my framebuffer. I wrote int 3 and I do see the pixel.

I am certain I am sending the right EOIs when needed, as they are always called at the end of my handlers before iret.
I don't have to send anything to 0xA0, as I'm not using any IRQs from the slave PIC.


Top
 Profile  
 
 Post subject: Re: [Real mode] PIT and Keyboard IRQs not firing on laptop
PostPosted: Mon Aug 08, 2022 1:33 pm 
Offline
Member
Member

Joined: Mon Mar 25, 2013 7:01 pm
Posts: 4145
What happens if, instead of sending the EOI yourself, you jump to the original timer ISR?

What happens if you leave the timer at its default settings instead of programming it for 30Hz?


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 

All times are UTC - 6 hours


Who is online

Users browsing this forum: Bing [Bot], Google [Bot], Majestic-12 [Bot] and 6 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group